Lines
79.35 %
Functions
46.46 %
Branches
100 %
#![cfg_attr(docsrs, feature(doc_cfg))]
#![doc = include_str!("../README.md")]
// @@ begin lint list maintained by maint/add_warning @@
#![allow(renamed_and_removed_lints)] // @@REMOVE_WHEN(ci_arti_stable)
#![allow(unknown_lints)] // @@REMOVE_WHEN(ci_arti_nightly)
#![warn(missing_docs)]
#![warn(noop_method_call)]
#![warn(unreachable_pub)]
#![warn(clippy::all)]
#![deny(clippy::await_holding_lock)]
#![deny(clippy::cargo_common_metadata)]
#![deny(clippy::cast_lossless)]
#![deny(clippy::checked_conversions)]
#![allow(clippy::cognitive_complexity)] // See arti#2556
#![deny(clippy::debug_assert_with_mut_call)]
#![deny(clippy::exhaustive_enums)]
#![deny(clippy::exhaustive_structs)]
#![deny(clippy::expl_impl_clone_on_copy)]
#![deny(clippy::fallible_impl_from)]
#![deny(clippy::implicit_clone)]
#![deny(clippy::large_stack_arrays)]
#![warn(clippy::manual_ok_or)]
#![deny(clippy::missing_docs_in_private_items)]
#![warn(clippy::needless_borrow)]
#![warn(clippy::needless_pass_by_value)]
#![warn(clippy::option_option)]
#![warn(clippy::or_fun_call)]
#![deny(clippy::print_stderr)]
#![deny(clippy::print_stdout)]
#![warn(clippy::rc_buffer)]
#![deny(clippy::ref_option_ref)]
#![warn(clippy::semicolon_if_nothing_returned)]
#![warn(clippy::trait_duplication_in_bounds)]
#![deny(clippy::unchecked_time_subtraction)]
#![deny(clippy::unnecessary_wraps)]
#![warn(clippy::unseparated_literal_suffix)]
#![deny(clippy::unwrap_used)]
#![deny(clippy::mod_module_files)]
#![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness
#![allow(clippy::uninlined_format_args)]
#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945
#![allow(clippy::result_large_err)] // temporary workaround for arti#587
#![allow(clippy::needless_raw_string_hashes)] // complained-about code is fine, often best
#![allow(clippy::needless_lifetimes)] // See arti#1765
#![allow(mismatched_lifetime_syntaxes)] // temporary workaround for arti#2060
#![allow(clippy::collapsible_if)] // See arti#2342
#![deny(clippy::unused_async)]
#![deny(clippy::string_slice)] // See arti#2571
#![allow(recursion_depth_exceeding_limit)] // arti#2715, rust/issues/159228
//! <!-- @@ end lint list maintained by maint/add_warning @@ -->
pub mod cmdline;
pub mod derive;
mod err;
#[macro_use]
pub mod extend_builder;
pub mod file_watcher;
mod flatten;
pub mod list_builder;
mod listen;
pub mod load;
pub mod map_builder;
mod misc;
pub mod mistrust;
mod mut_cfg;
pub mod setter_traits;
pub mod sources;
#[cfg(feature = "testing")]
pub mod testing;
#[doc(hidden)]
pub mod deps {
pub use educe;
pub use figment;
pub use itertools::Itertools;
pub use paste::paste;
pub use serde;
pub use serde_value;
pub use tor_basic_utils::{if_empty, macro_first_nonempty};
}
pub use cmdline::CmdLine;
pub use err::{ConfigBuildError, ConfigError, ConfigGetValueError, ReconfigureError};
pub use flatten::{Flatten, Flattenable};
pub use list_builder::{MultilineListBuilder, MultilineListBuilderError};
pub use listen::*;
pub use load::{resolve, resolve_ignore_warnings, resolve_return_results};
pub use misc::*;
pub use mut_cfg::MutCfg;
use serde::de::DeserializeOwned;
pub use sources::{ConfigurationSource, ConfigurationSources};
use tor_error::into_internal;
pub use derive_deftly;
pub use flatten::flattenable_extract_fields;
derive_deftly::template_export_semver_check! { "0.12.1" }
/// A set of configuration fields, represented as a set of nested K=V
/// mappings.
///
/// (This is a wrapper for an underlying type provided by the library that
/// actually does our configuration.)
#[derive(Clone, Debug, Default)]
#[must_use] // to prevent errors from merge_from.
pub struct ConfigurationTree(figment::Figment);
impl ConfigurationTree {
#[cfg(test)]
pub(crate) fn get_string(&self, key: &str) -> Result<String, crate::ConfigError> {
use figment::value::Value as V;
let val = self.0.find_value(key).map_err(ConfigError::from_cfg_err)?;
Ok(match val {
V::String(_, s) => s.clone(),
V::Num(_, n) => n.to_i128().expect("Failed to extract i128").to_string(),
_ => format!("{:?}", val),
})
/// Return the value with a given key as some type that implements Deserialize.
/// Return `None` if no such value is set in this tree.
pub fn get_serde_value<T: DeserializeOwned>(
&self,
key: &str,
) -> Result<Option<T>, ConfigGetValueError> {
use figment::error::{Error as FError, Kind::MissingField};
match self.0.extract_inner(key) {
Ok(v) => Ok(Some(v)),
Err(FError {
kind: MissingField(..),
..
}) => Ok(None),
Err(e) => Err(into_internal!("Unexpected error looking up config value")(e).into()),
/// Override our current tree with the settings in `config`.
/// `config` must be implement [`Serialize`](serde::Serialize),
/// and must serialize to a map.
/// This operation follows the same as are used when reading
/// multiple configuration files in sequence,
/// where option settings in later files replace earlier ones.
#[allow(clippy::unnecessary_wraps)]
pub fn merge_from<T>(&mut self, config: &T) -> Result<(), ConfigError>
where
T: serde::Serialize,
{
let provider = figment::providers::Serialized::from(config, figment::Profile::Default);
let mut orig = figment::Figment::new();
std::mem::swap(&mut orig, &mut self.0);
self.0 = orig.merge(provider);
// Figment::merge handles errors by making the type of the figment itself into an error...
// but we don't want our API to rely on that, so we let method returna Result.
Ok(())
/// Rules for reconfiguring a running Arti instance.
#[derive(Debug, Clone, Copy, Eq, PartialEq)]
#[non_exhaustive]
pub enum Reconfigure {
/// Perform no reconfiguration unless we can guarantee that all changes will be successful.
AllOrNothing,
/// Try to reconfigure as much as possible; warn on fields that we cannot reconfigure.
WarnOnFailures,
/// Don't reconfigure anything: Only check whether we can guarantee that all changes will be successful.
CheckAllOrNothing,
impl Reconfigure {
/// Called when we see a disallowed attempt to change `field`: either give a ReconfigureError,
/// or warn and return `Ok(())`, depending on the value of `self`.
pub fn cannot_change<S: AsRef<str>>(self, field: S) -> Result<(), ReconfigureError> {
match self {
Reconfigure::AllOrNothing | Reconfigure::CheckAllOrNothing => {
Err(ReconfigureError::CannotChange {
field: field.as_ref().to_owned(),
Reconfigure::WarnOnFailures => {
tracing::warn!("Cannot change {} on a running client.", field.as_ref());
/// As `cannot_change`, but return a [`ReconfigureError::CannotChangeToValue`] variant.
/// `manner` should be an adverbial preprositional phrase,
/// like "from on to off" or "while arti is running".
pub fn cannot_change_specific<S, T>(self, field: S, manner: T) -> Result<(), ReconfigureError>
S: AsRef<str>,
T: AsRef<str>,
Err(ReconfigureError::CannotChangeToValue {
manner: manner.as_ref().to_owned(),
tracing::warn!(
"Cannot change {} {} on a running client.",
field.as_ref(),
manner.as_ref()
);
/// Resolves an `Option<Option<T>>` (in a builder) into an `Option<T>`
/// * If the input is `None`, this indicates that the user did not specify a value,
/// and we therefore use `def` to obtain the default value.
/// * If the input is `Some(None)`, or `Some(Some(Default::default()))`,
/// the user has explicitly specified that this config item should be null/none/nothing,
/// so we return `None`.
/// * Otherwise the user provided an actual value, and we return `Some` of it.
/// See <https://gitlab.torproject.org/tpo/core/arti/-/issues/488>
/// For consistency with other APIs in Arti, when using this,
/// do not pass `setter(strip_option)` to derive_builder.
/// # âš Stability Warning âš
/// We may significantly change this so that it is an method in an extension trait.
//
// This is an annoying AOI right now because you have to write things like
// #[builder(field(build = r#"tor_config::resolve_option(&self.dns_port, || None)"#))]
// pub(crate) dns_port: Option<u16>,
// which recapitulates the field name. That is very much a bug hazard (indeed, in an
// early version of some of this code I perpetrated precisely that bug).
// Fixing this involves a derive_builder feature.
pub fn resolve_option<T, DF>(input: &Option<Option<T>>, def: DF) -> Option<T>
T: Clone + Default + PartialEq,
DF: FnOnce() -> Option<T>,
resolve_option_general(
input.as_ref().map(|ov| ov.as_ref()),
|v| v == &T::default(),
def,
)
/// Resolves an `Option<Option<&T>>` (in a builder) into an `Option<T>`, more generally
/// Like [`resolve_option`], but:
/// * Doesn't rely on `T` being `Default + PartialEq`
/// to determine whether it's the sentinel value;
/// instead, takes `is_sentinel`.
/// * Takes `Option<Option<&T>>` which is more general, but less like the usual call sites.
/// # Behavior
/// * If the input is `Some(None)`, or `Some(Some(v))` where `is_sentinel(v)` returns true,
/// # Example
/// ```
/// use tor_config::resolve_option_general;
/// // Use 0 as a sentinel meaning "explicitly clear" in this example
/// let is_sentinel = |v: &i32| *v == 0;
/// // No value provided: use default
/// assert_eq!(
/// resolve_option_general(None, is_sentinel, || Some(10)),
/// Some(10),
/// );
/// // Explicitly None
/// resolve_option_general(Some(None), is_sentinel, || Some(10)),
/// None,
/// // Sentinel value (0) -> return None
/// resolve_option_general(Some(Some(&0)), is_sentinel, || Some(10)),
/// // Set to actual value -> return that value
/// resolve_option_general(Some(Some(&5)), is_sentinel, || Some(10)),
/// Some(5),
pub fn resolve_option_general<T, ISF, DF>(
input: Option<Option<&T>>,
is_sentinel: ISF,
def: DF,
) -> Option<T>
T: Clone,
ISF: FnOnce(&T) -> bool,
match input {
None => def(),
Some(None) => None,
Some(Some(v)) if is_sentinel(v) => None,
Some(Some(v)) => Some(v.clone()),
/// Defines standard impls for a struct with a `Builder`, incl `Default`
/// **Use this.** Do not `#[derive(Builder, Default)]`. That latter approach would produce
/// wrong answers if builder attributes are used to specify non-`Default` default values.
/// # Input syntax
/// use derive_builder::Builder;
/// use serde::{Deserialize, Serialize};
/// use tor_config::impl_standard_builder;
/// use tor_config::ConfigBuildError;
/// #[derive(Debug, Builder, Clone, Eq, PartialEq)]
/// #[builder(derive(Serialize, Deserialize, Debug))]
/// #[builder(build_fn(error = "ConfigBuildError"))]
/// struct SomeConfigStruct { }
/// impl_standard_builder! { SomeConfigStruct }
/// struct UnusualStruct { }
/// impl_standard_builder! { UnusualStruct: !Deserialize + !Builder }
/// # Requirements
/// `$Config`'s builder must have default values for all the fields,
/// or this macro-generated self-test will fail.
/// This should be OK for all principal elements of our configuration.
/// `$ConfigBuilder` must have an appropriate `Deserialize` impl.
/// # Options
/// * `!Default` suppresses the `Default` implementation, and the corresponding tests.
/// This should be done within Arti's configuration only for sub-structures which
/// contain mandatory fields (and are themselves optional).
/// * `!Deserialize` suppresses the test case involving `Builder: Deserialize`.
/// This should not be done for structs which are part of Arti's configuration,
/// but can be appropriate for other types that use [`derive_builder`].
/// * `!Builder` suppresses the impl of the [`tor_config::load::Builder`](load::Builder) trait
/// This will be necessary if the error from the builder is not [`ConfigBuildError`].
/// # Generates
/// * `impl Default for $Config`
/// * `impl Builder for $ConfigBuilder`
/// * a self-test that the `Default` impl actually works
/// * a test that the `Builder` can be deserialized from an empty [`ConfigurationTree`],
/// and then built, and that the result is the same as the ordinary default.
// The implementation munches fake "trait bounds" (`: !Deserialize + !Wombat ...`) off the RHS.
// We're going to add at least one more option.
// When run with `!Default`, this only generates a `builder` impl and an impl of
// the `Resolvable` trait which probably won't be used anywhere. That may seem
// like a poor tradeoff (much fiddly macro code to generate a trivial function in
// a handful of call sites). However, this means that `impl_standard_builder!`
// can be used in more places. That sets a good example: always use the macro.
// That is a good example because we want `impl_standard_builder!` to be
// used elsewhere because it generates necessary tests of properties
// which might otherwise be violated. When adding code, people add according to the
// patterns they see.
// (We, sadly, don't have a good way to *ensure* use of `impl_standard_builder`.)
#[macro_export]
macro_rules! impl_standard_builder {
// Convert the input into the "being processed format":
$Config:ty $(: $($options:tt)* )?
} => { $crate::impl_standard_builder!{
// ^Being processed format:
@ ( Builder )
( default )
( extract ) $Config : $( $( $options )* )?
// ~~~~~~~~~~~~~~~ ^^^^^^^ ^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
// present iff not !Builder, !Default
// present iff not !Default
// present iff not !Deserialize type always present options yet to be parsed
} };
// If !Deserialize is the next option, implement it by making $try_deserialize absent
@ ( $($Builder :ident)? )
( $($default :ident)? )
( $($try_deserialize:ident)? ) $Config:ty : $(+)? !Deserialize $( $options:tt )*
@ ( $($Builder )? )
( $($default )? )
( ) $Config : $( $options )*
// If !Builder is the next option, implement it by making $Builder absent
( $($try_deserialize:ident)? ) $Config:ty : $(+)? !Builder $( $options:tt )*
@ ( )
( $($try_deserialize )? ) $Config : $( $options )*
// If !Default is the next option, implement it by making $default absent
( $($try_deserialize:ident)? ) $Config:ty : $(+)? !Default $( $options:tt )*
( )
// Having parsed all options, produce output:
( $($try_deserialize:ident)? ) $Config:ty : $(+)?
} => { $crate::deps::paste!{
impl $Config {
/// Returns a fresh, default, builder
pub fn builder() -> [< $Config Builder >] {
Default::default()
$( // expands iff there was $default, which is always default
impl Default for $Config {
fn $default() -> Self {
// unwrap is good because one of the test cases above checks that it works!
[< $Config Builder >]::default().build().unwrap()
)?
$( // expands iff there was $Builder, which is always Builder
impl $crate::load::$Builder for [< $Config Builder >] {
type Built = $Config;
fn build(&self) -> std::result::Result<$Config, $crate::ConfigBuildError> {
[< $Config Builder >]::build(self)
#[test]
#[allow(non_snake_case)]
fn [< test_impl_Default_for_ $Config >] () {
#[allow(unused_variables)]
let def = None::<$Config>;
let def = Some($Config::$default());
if let Some(def) = def {
$( // expands iff there was $try_deserialize, which is always extract
let empty_config = $crate::deps::figment::Figment::new();
let builder: [< $Config Builder >] = empty_config.$try_deserialize().unwrap();
let from_empty = builder.build().unwrap();
assert_eq!(def, from_empty);
)*
mod test {
// @@ begin test lint list maintained by maint/add_warning @@
#![allow(clippy::bool_assert_comparison)]
#![allow(clippy::clone_on_copy)]
#![allow(clippy::dbg_macro)]
#![allow(clippy::mixed_attributes_style)]
#![allow(clippy::print_stderr)]
#![allow(clippy::print_stdout)]
#![allow(clippy::single_char_pattern)]
#![allow(clippy::unwrap_used)]
#![allow(clippy::unchecked_time_subtraction)]
#![allow(clippy::useless_vec)]
#![allow(clippy::needless_pass_by_value)]
#![allow(clippy::string_slice)] // See arti#2571
//! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
use super::*;
use crate::{self as tor_config, sources::MustRead};
use derive_builder::Builder;
use serde::{Deserialize, Serialize};
use serde_json::json;
use tracing_test::traced_test;
#[traced_test]
fn reconfigure_helpers() {
let how = Reconfigure::AllOrNothing;
let err = how.cannot_change("the_laws_of_physics").unwrap_err();
assert_eq!(
err.to_string(),
"Cannot change the_laws_of_physics on a running client.".to_owned()
let how = Reconfigure::WarnOnFailures;
let ok = how.cannot_change("stuff");
assert!(ok.is_ok());
assert!(logs_contain("Cannot change stuff on a running client."));
#[rustfmt::skip] // autoformatting obscures the regular structure
fn resolve_option_test() {
#[derive(Debug, Clone, Builder, Eq, PartialEq)]
#[builder(build_fn(error = "ConfigBuildError"))]
#[builder(derive(Debug, Serialize, Deserialize, Eq, PartialEq))]
struct TestConfig {
#[builder(field(build = r#"tor_config::resolve_option(&self.none, || None)"#))]
none: Option<u32>,
#[builder(field(build = r#"tor_config::resolve_option(&self.four, || Some(4))"#))]
four: Option<u32>,
// defaults
let builder_from_json: TestConfigBuilder = serde_json::from_value(
json!{ { } }
).unwrap();
let builder_from_methods = TestConfigBuilder::default();
assert_eq!(builder_from_methods, builder_from_json);
assert_eq!(builder_from_methods.build().unwrap(),
TestConfig { none: None, four: Some(4) });
// explicit positive values
json!{ { "none": 123, "four": 456 } }
let mut builder_from_methods = TestConfigBuilder::default();
builder_from_methods.none(Some(123));
builder_from_methods.four(Some(456));
TestConfig { none: Some(123), four: Some(456) });
// explicit "null" values
json!{ { "none": 0, "four": 0 } }
builder_from_methods.none(Some(0));
builder_from_methods.four(Some(0));
TestConfig { none: None, four: None });
// explicit None (API only, serde can't do this for Option)
builder_from_methods.none(None);
builder_from_methods.four(None);
fn get_value() {
use serde_value::Value as V;
let to_value = |json_str: &str| {
serde_value::to_value(serde_json::from_str::<serde_json::Value>(json_str).unwrap())
.unwrap()
};
let mut sources = ConfigurationSources::new_empty();
let source = "
[foo]
bar.baz = 7
quux = [[],[],{}]
";
let source = ConfigurationSource::from_verbatim(source.to_string());
sources.push_source(source, MustRead::MustRead);
let tree = sources.load().unwrap();
let v1 = tree.get_serde_value::<V>("foo.quux").unwrap().unwrap();
let v2 = to_value(r#"[[], [], {}]"#);
assert_eq!(v1, v2);
assert!(tree.get_serde_value::<V>("nonexist").unwrap().is_none());
assert!(tree.get_serde_value::<V>("foo.nonexist").unwrap().is_none());
assert!(
tree.get_serde_value::<V>("foo.quux.nonexist")
.is_none()