1
#![cfg_attr(docsrs, feature(doc_cfg))]
2
#![doc = include_str!("../README.md")]
3
// @@ begin lint list maintained by maint/add_warning @@
4
#![allow(renamed_and_removed_lints)] // @@REMOVE_WHEN(ci_arti_stable)
5
#![allow(unknown_lints)] // @@REMOVE_WHEN(ci_arti_nightly)
6
#![warn(missing_docs)]
7
#![warn(noop_method_call)]
8
#![warn(unreachable_pub)]
9
#![warn(clippy::all)]
10
#![deny(clippy::await_holding_lock)]
11
#![deny(clippy::cargo_common_metadata)]
12
#![deny(clippy::cast_lossless)]
13
#![deny(clippy::checked_conversions)]
14
#![warn(clippy::cognitive_complexity)]
15
#![deny(clippy::debug_assert_with_mut_call)]
16
#![deny(clippy::exhaustive_enums)]
17
#![deny(clippy::exhaustive_structs)]
18
#![deny(clippy::expl_impl_clone_on_copy)]
19
#![deny(clippy::fallible_impl_from)]
20
#![deny(clippy::implicit_clone)]
21
#![deny(clippy::large_stack_arrays)]
22
#![warn(clippy::manual_ok_or)]
23
#![deny(clippy::missing_docs_in_private_items)]
24
#![warn(clippy::needless_borrow)]
25
#![warn(clippy::needless_pass_by_value)]
26
#![warn(clippy::option_option)]
27
#![deny(clippy::print_stderr)]
28
#![deny(clippy::print_stdout)]
29
#![warn(clippy::rc_buffer)]
30
#![deny(clippy::ref_option_ref)]
31
#![warn(clippy::semicolon_if_nothing_returned)]
32
#![warn(clippy::trait_duplication_in_bounds)]
33
#![deny(clippy::unchecked_time_subtraction)]
34
#![deny(clippy::unnecessary_wraps)]
35
#![warn(clippy::unseparated_literal_suffix)]
36
#![deny(clippy::unwrap_used)]
37
#![deny(clippy::mod_module_files)]
38
#![allow(clippy::let_unit_value)] // This can reasonably be done for explicitness
39
#![allow(clippy::uninlined_format_args)]
40
#![allow(clippy::significant_drop_in_scrutinee)] // arti/-/merge_requests/588/#note_2812945
41
#![allow(clippy::result_large_err)] // temporary workaround for arti#587
42
#![allow(clippy::needless_raw_string_hashes)] // complained-about code is fine, often best
43
#![allow(clippy::needless_lifetimes)] // See arti#1765
44
#![allow(mismatched_lifetime_syntaxes)] // temporary workaround for arti#2060
45
#![allow(clippy::collapsible_if)] // See arti#2342
46
#![deny(clippy::unused_async)]
47
//! <!-- @@ end lint list maintained by maint/add_warning @@ -->
48

            
49
use std::fmt::{Display, Formatter, Write};
50
use std::num::NonZeroUsize;
51
use std::str::FromStr;
52

            
53
mod err;
54
use digest::Digest;
55
pub use err::Error;
56
use imara_diff::{Algorithm, Diff, Hunk, InternedInput};
57
use tor_error::internal;
58
use tor_netdoc::parse2::{ErrorProblem, ItemStream, KeywordRef, ParseError, ParseInput};
59

            
60
use crate::err::GenEdDiffError;
61

            
62
/// Result type used by this crate
63
type Result<T> = std::result::Result<T, Error>;
64

            
65
/// The keyword that identifies a directory signature line.
66
// TODO: We probably want this in tor-netdoc.
67
const DIRECTORY_SIGNATURE_KEYWORD: KeywordRef = KeywordRef::new_const("directory-signature");
68

            
69
/// When hashing the signed part of the consensus, append this tail to the end.
70
const CONSENSUS_SIGNED_SHA3_256_HASH_TAIL: &str = "directory-signature ";
71

            
72
// Do not compile if we cannot safely convert a u32 into a usize.
73
static_assertions::const_assert!(std::mem::size_of::<usize>() >= std::mem::size_of::<u32>());
74

            
75
/// Generates a consensus diff.
76
///
77
/// This implementation is different from the one in CTor, because it uses a
78
/// different algorithm, namely [`Algorithm::Myers`] from the [`imara_diff`]
79
/// crate, which is more efficient than CTor in terms of runtime and about as
80
/// equally efficient as CTor in output size.
81
///
82
/// The CTor implementation makes heavy use of the fact that the input is a
83
/// valid consensus and that the routers in it are ordered.  This allows for
84
/// some divide-and-conquer mechanisms and the cost of requiring more parsing.
85
///
86
/// Here, we only minimally parse the consensus, in order to only obtain the
87
/// first `directory-signature` item and to cut everything including itself off
88
/// from the input, as demanded by the specification.
89
///
90
/// All outputs of this function are guaranteed to work with this
91
/// [`apply_diff()`] implementation as a check is performed before returning,
92
/// because returning an unusable diff would be terrible.
93
41
pub fn gen_cons_diff(base: &str, target: &str) -> Result<String> {
94
    // Throw away the signatures.
95
41
    let (base_signed, _) = split_directory_signatures(base)?;
96
184597
    let base_lines = base_signed.chars().filter(|c| *c == '\n').count() + 1;
97

            
98
    // Compute the hashes for the header.
99
41
    let base_signed_hash = hex::encode_upper({
100
41
        let mut h = tor_llcrypto::d::Sha3_256::new();
101
41
        h.update(base_signed);
102
41
        h.update(CONSENSUS_SIGNED_SHA3_256_HASH_TAIL);
103
41
        h.finalize()
104
    });
105
41
    let target_hash = hex::encode_upper(tor_llcrypto::d::Sha3_256::digest(target.as_bytes()));
106

            
107
    // Compose the result with header.
108
41
    let ed_diff = gen_ed_diff(base_signed, target).map_err(|e| match e {
109
        GenEdDiffError::MissingUnixLineEnding { lno } => Error::InvalidInput(ParseError::new(
110
            ErrorProblem::OtherBadDocument("line does not end with '\\n'"),
111
            "consdiff",
112
            "",
113
            lno,
114
            None,
115
        )),
116
        GenEdDiffError::ContainsDotLine { lno } => Error::InvalidInput(ParseError::new(
117
            ErrorProblem::OtherBadDocument("contains dotline"),
118
            "consdiff",
119
            "",
120
            lno,
121
            None,
122
        )),
123
        GenEdDiffError::Write(_) => internal!("string write was not infallible?").into(),
124
    })?;
125

            
126
41
    let result = format!(
127
41
        "network-status-diff-version 1\n\
128
41
        hash {base_signed_hash} {target_hash}\n\
129
41
        {base_lines},$d\n\
130
41
        {ed_diff}"
131
    );
132

            
133
    // Ensure it is valid, refuse to emit an invalid diff.
134
41
    let check = apply_diff(base, &result, None).map_err(|_| internal!("apply call failed"))?;
135
41
    if check.to_string() != target {
136
        Err(internal!("result does not match?"))?;
137
41
    }
138

            
139
41
    Ok(result)
140
41
}
141

            
142
/// Splits `input` at the first `directory-signature`.
143
41
fn split_directory_signatures(input: &str) -> Result<(&str, &str)> {
144
41
    let parse_input = ParseInput::new(input, "");
145
41
    let mut items = ItemStream::new(&parse_input)?;
146

            
147
    // Parse the consensus item by item until the first `directory-signature`.
148
    loop {
149
        // We only peek in order to get the proper byte offset.
150
        // This is required because doing next() and breaking in the case of
151
        // a `directory-signature` would then lead to `.byte_offset()` yielding
152
        // the start of the second signature and not the start of the first one.
153
4816
        let item = items
154
4816
            .peek_keyword()
155
4816
            .map_err(|e| ParseError::new(e, "consdiff", "", items.lno_for_error(), None))?;
156

            
157
4816
        match item {
158
4816
            Some(DIRECTORY_SIGNATURE_KEYWORD) => {
159
41
                let offset = items.byte_position();
160
41
                return Ok((&input[..offset], &input[offset..]));
161
            }
162
4775
            Some(_) => {
163
4775
                // Consume the just peeked item.
164
4775
                let _ = items.next();
165
4775
            }
166
            None => {
167
                // We are finished.
168
                return Err(Error::InvalidInput(ParseError::new(
169
                    ErrorProblem::MissingItem {
170
                        keyword: DIRECTORY_SIGNATURE_KEYWORD.as_str(),
171
                    },
172
                    "consdiff",
173
                    "",
174
                    items.lno_for_error(),
175
                    None,
176
                )));
177
            }
178
        }
179
    }
180
41
}
181

            
182
/// Generates an input agnostic ed diff.
183
///
184
/// This function does the general logic of [`gen_cons_diff()`] but works in a
185
/// document agnostic fashion.
186
51
fn gen_ed_diff(base: &str, target: &str) -> std::result::Result<String, GenEdDiffError> {
187
51
    let mut result = String::new();
188

            
189
    // We use Myers' algorithm as benchmarks have shown that it provides an
190
    // equal diff size as the ctor one while keeping an acceptable performance.
191
51
    let input = InternedInput::new(base, target);
192
51
    let mut diff = Diff::compute(Algorithm::Myers, &input);
193
51
    diff.postprocess_lines(&input);
194

            
195
    // Iterate through every a hunk, with a hunk being a block of changes.
196
51
    let hunks = diff.hunks().collect::<Vec<_>>();
197
991
    for hunk in hunks.into_iter().rev() {
198
        // Format the header.
199
991
        let hunk_type = HunkType::determine(&hunk);
200
991
        match hunk_type {
201
            // No need to do +1 because append is AFTER.
202
215
            HunkType::Append => writeln!(result, "{}{hunk_type}", hunk.before.start)?,
203
            HunkType::Delete | HunkType::Change => {
204
776
                if hunk.before.start + 1 == hunk.before.end {
205
                    // +1 because 1-indexed.
206
270
                    writeln!(result, "{}{hunk_type}", hunk.before.start + 1)?;
207
                } else {
208
                    // +1 because 1-indexed; no need to do +1 on end because
209
                    // the range is inclusive.
210
506
                    writeln!(
211
506
                        result,
212
506
                        "{},{}{hunk_type}",
213
506
                        hunk.before.start + 1,
214
                        hunk.before.end
215
                    )?;
216
                }
217
            }
218
        }
219

            
220
        // Format the body.
221
991
        match hunk_type {
222
            HunkType::Append | HunkType::Change => {
223
772
                let range = (hunk.after.start)..(hunk.after.end);
224
772
                let tlines = range
225
3010
                    .map(|idx| {
226
2764
                        let idx = usize::try_from(idx).expect("32-bit static assertion violated?");
227
2764
                        input.interner[input.after[idx]]
228
2764
                    })
229
772
                    .collect::<Vec<_>>();
230

            
231
2750
                for (lno, line) in tlines.iter().copied().enumerate() {
232
                    // Check that all lines end with a Unix line ending.
233
2750
                    if line.ends_with("\r\n") || !line.ends_with("\n") {
234
                        // +1 because 1-indexed.
235
4
                        return Err(GenEdDiffError::MissingUnixLineEnding { lno: lno + 1 });
236
2746
                    }
237

            
238
                    // Check for lines consisting of a single dot plus trailing
239
                    // whitespace characters.  No need to bother about "\r\n",
240
                    // because we checked that one above.  Although technically
241
                    // lines such as `. \n` are possible and understood
242
                    // as part of ed diffs, they are not legal in tor netdocs, and
243
                    // we want to be more defensive here for now; if it becomes a
244
                    // problem, we may remove it later.
245
2746
                    if line.trim_end() == "." {
246
                        // +1 because 1-indexed.
247
4
                        return Err(GenEdDiffError::ContainsDotLine { lno: lno + 1 });
248
2742
                    }
249

            
250
                    // All lines are newline terminated, no need to use writeln!
251
2742
                    write!(result, "{line}")?;
252
                }
253

            
254
                // Write the terminating dot.
255
764
                writeln!(result, ".")?;
256
            }
257
219
            HunkType::Delete => {}
258
        }
259
    }
260

            
261
43
    Ok(result)
262
51
}
263

            
264
/// The operational type of the hunk.
265
#[derive(Clone, Copy, Debug, derive_more::Display)]
266
enum HunkType {
267
    /// This is a pure appending.
268
    #[display("a")]
269
    Append,
270
    /// This is a pure deletion.
271
    #[display("d")]
272
    Delete,
273
    /// This is change with potential additions and deletions.
274
    #[display("c")]
275
    Change,
276
}
277

            
278
impl HunkType {
279
    /// Determines the type of the hunk.
280
991
    fn determine(hunk: &Hunk) -> Self {
281
991
        if hunk.is_pure_insertion() {
282
215
            Self::Append
283
776
        } else if hunk.is_pure_removal() {
284
219
            Self::Delete
285
        } else {
286
557
            Self::Change
287
        }
288
991
    }
289
}
290

            
291
/// Return true if `s` looks more like a consensus diff than some other kind
292
/// of document.
293
148
pub fn looks_like_diff(s: &str) -> bool {
294
148
    s.starts_with("network-status-diff-version")
295
148
}
296

            
297
/// Apply a given diff to an input text, and return the result from applying
298
/// that diff.
299
///
300
/// This is a slow version, for testing and correctness checking.  It uses
301
/// an O(n) operation to apply diffs, and therefore runs in O(n^2) time.
302
#[cfg(any(test, feature = "slow-diff-apply"))]
303
2
pub fn apply_diff_trivial<'a>(input: &'a str, diff: &'a str) -> Result<DiffResult<'a>> {
304
2
    let mut diff_lines = diff.lines();
305
2
    let (_, d2) = parse_diff_header(&mut diff_lines)?;
306

            
307
2
    let mut diffable = DiffResult::from_str(input, d2);
308

            
309
24
    for command in DiffCommandIter::new(diff_lines) {
310
24
        command?.apply_to(&mut diffable)?;
311
    }
312

            
313
2
    Ok(diffable)
314
2
}
315

            
316
/// Apply a given diff to an input text, and return the result from applying
317
/// that diff.
318
///
319
/// If `check_digest_in` is provided, require the diff to say that it
320
/// applies to a document with the provided digest.
321
191
pub fn apply_diff<'a>(
322
191
    input: &'a str,
323
191
    diff: &'a str,
324
191
    check_digest_in: Option<[u8; 32]>,
325
191
) -> Result<DiffResult<'a>> {
326
191
    let mut input = DiffResult::from_str(input, [0; 32]);
327

            
328
191
    let mut diff_lines = diff.lines();
329
191
    let (d1, d2) = parse_diff_header(&mut diff_lines)?;
330
191
    if let Some(d_want) = check_digest_in {
331
74
        if d1 != d_want {
332
            return Err(Error::CantApply("listed digest does not match document"));
333
74
        }
334
117
    }
335

            
336
191
    let mut output = DiffResult::new(d2);
337

            
338
2558
    for command in DiffCommandIter::new(diff_lines) {
339
2558
        command?.apply_transformation(&mut input, &mut output)?;
340
    }
341

            
342
191
    output.push_reversed(&input.lines[..]);
343

            
344
191
    output.lines.reverse();
345
191
    Ok(output)
346
191
}
347

            
348
/// Given a line iterator, check to make sure the first two lines are
349
/// a valid diff header as specified in dir-spec.txt.
350
213
fn parse_diff_header<'a, I>(iter: &mut I) -> Result<([u8; 32], [u8; 32])>
351
213
where
352
213
    I: Iterator<Item = &'a str>,
353
{
354
213
    let line1 = iter.next();
355
213
    if line1 != Some("network-status-diff-version 1") {
356
6
        return Err(Error::BadDiff("unrecognized or missing header"));
357
207
    }
358
207
    let line2 = iter.next().ok_or(Error::BadDiff("header truncated"))?;
359
205
    if !line2.starts_with("hash ") {
360
2
        return Err(Error::BadDiff("missing 'hash' line"));
361
203
    }
362
203
    let elts: Vec<_> = line2.split_ascii_whitespace().collect();
363
203
    if elts.len() != 3 {
364
2
        return Err(Error::BadDiff("invalid 'hash' line"));
365
201
    }
366
201
    let d1 = hex::decode(elts[1])?;
367
197
    let d2 = hex::decode(elts[2])?;
368
197
    match (d1.try_into(), d2.try_into()) {
369
195
        (Ok(a), Ok(b)) => Ok((a, b)),
370
2
        _ => Err(Error::BadDiff("wrong digest lengths on 'hash' line")),
371
    }
372
213
}
373

            
374
/// A command that can appear in a diff.  Each command tells us to
375
/// remove zero or more lines, and insert zero or more lines in their
376
/// place.
377
///
378
/// Commands refer to lines by 1-indexed line number.
379
#[derive(Clone, Debug)]
380
enum DiffCommand<'a> {
381
    /// Remove the lines from low through high, inclusive.
382
    Delete {
383
        /// The first line to remove
384
        low: usize,
385
        /// The last line to remove
386
        high: usize,
387
    },
388
    /// Remove the lines from low through the end of the file, inclusive.
389
    DeleteToEnd {
390
        /// The first line to remove
391
        low: usize,
392
    },
393
    /// Replace the lines from low through high, inclusive, with the
394
    /// lines in 'lines'.
395
    Replace {
396
        /// The first line to replace
397
        low: usize,
398
        /// The last line to replace
399
        high: usize,
400
        /// The text to insert instead
401
        lines: Vec<&'a str>,
402
    },
403
    /// Insert the provided 'lines' after the line with index 'pos'.
404
    Insert {
405
        /// The position after which to insert the text
406
        pos: usize,
407
        /// The text to insert
408
        lines: Vec<&'a str>,
409
    },
410
}
411

            
412
/// The result of applying one or more diff commands to an input string.
413
///
414
/// It refers to lines from the diff and the input by reference, to
415
/// avoid copying.
416
#[derive(Clone, Debug)]
417
pub struct DiffResult<'a> {
418
    /// An expected digest of the output, after it has been assembled.
419
    d_post: [u8; 32],
420
    /// The lines in the output.
421
    lines: Vec<&'a str>,
422
}
423

            
424
/// A possible value for the end of a range.  It can be either a line number,
425
/// or a dollar sign indicating "end of file".
426
#[derive(Clone, Copy, Debug)]
427
enum RangeEnd {
428
    /// A line number in the file.
429
    Num(NonZeroUsize),
430
    /// A dollar sign, indicating "end of file" in a delete command.
431
    DollarSign,
432
}
433

            
434
impl FromStr for RangeEnd {
435
    type Err = Error;
436
1436
    fn from_str(s: &str) -> Result<RangeEnd> {
437
1436
        if s == "$" {
438
123
            Ok(RangeEnd::DollarSign)
439
        } else {
440
1313
            let v: NonZeroUsize = s.parse()?;
441
1311
            if v.get() == usize::MAX {
442
2
                return Err(Error::BadDiff("range cannot end at usize::MAX"));
443
1309
            }
444
1309
            Ok(RangeEnd::Num(v))
445
        }
446
1436
    }
447
}
448

            
449
impl<'a> DiffCommand<'a> {
450
    /// Transform 'target' according to the this command.
451
    ///
452
    /// Because DiffResult internally uses a vector of line, this
453
    /// implementation is potentially O(n) in the size of the input.
454
    #[cfg(any(test, feature = "slow-diff-apply"))]
455
32
    fn apply_to(&self, target: &mut DiffResult<'a>) -> Result<()> {
456
32
        match self {
457
8
            Self::Delete { low, high } => {
458
8
                target.remove_lines(*low, *high)?;
459
            }
460
4
            Self::DeleteToEnd { low } => {
461
4
                target.remove_lines(*low, target.lines.len())?;
462
            }
463
16
            Self::Replace { low, high, lines } => {
464
16
                target.remove_lines(*low, *high)?;
465
16
                target.insert_at(*low, lines)?;
466
            }
467
4
            Self::Insert { pos, lines } => {
468
                // This '+1' seems off, but it's what the spec says. I wonder
469
                // if the spec is wrong.
470
4
                target.insert_at(*pos + 1, lines)?;
471
            }
472
        };
473
32
        Ok(())
474
32
    }
475

            
476
    /// Apply this command to 'input', moving lines into 'output'.
477
    ///
478
    /// This is a more efficient algorithm, but it requires that the
479
    /// diff commands are sorted in reverse order by line
480
    /// number. (Fortunately, the Tor ed diff format guarantees this.)
481
    ///
482
    /// Before calling this method, input and output must contain the
483
    /// results of having applied the previous command in the diff.
484
    /// (When no commands have been applied, input starts out as the
485
    /// original text, and output starts out empty.)
486
    ///
487
    /// This method applies the command by copying unaffected lines
488
    /// from the _end_ of input into output, adding any lines inserted
489
    /// by this command, and finally deleting any affected lines from
490
    /// input.
491
    ///
492
    /// We build the `output` value in reverse order, and then put it
493
    /// back to normal before giving it to the user.
494
2578
    fn apply_transformation(
495
2578
        &self,
496
2578
        input: &mut DiffResult<'a>,
497
2578
        output: &mut DiffResult<'a>,
498
2578
    ) -> Result<()> {
499
2578
        if let Some(succ) = self.following_lines() {
500
2455
            if let Some(subslice) = input.lines.get(succ - 1..) {
501
2451
                // Lines from `succ` onwards are unaffected.  Copy them.
502
2451
                output.push_reversed(subslice);
503
2451
            } else {
504
                // Oops, dubious line number.
505
4
                return Err(Error::CantApply(
506
4
                    "ending line number didn't correspond to document",
507
4
                ));
508
            }
509
123
        }
510

            
511
2574
        if let Some(lines) = self.lines() {
512
1898
            // These are the lines we're inserting.
513
1898
            output.push_reversed(lines);
514
1898
        }
515

            
516
2574
        let remove = self.first_removed_line();
517
2574
        if remove == 0 || (!self.is_insert() && remove > input.lines.len()) {
518
4
            return Err(Error::CantApply(
519
4
                "starting line number didn't correspond to document",
520
4
            ));
521
2570
        }
522
2570
        input.lines.truncate(remove - 1);
523

            
524
2570
        Ok(())
525
2578
    }
526

            
527
    /// Return the lines that we should add to the output
528
2582
    fn lines(&self) -> Option<&[&'a str]> {
529
2582
        match self {
530
1906
            Self::Replace { lines, .. } | Self::Insert { lines, .. } => Some(lines.as_slice()),
531
676
            _ => None,
532
        }
533
2582
    }
534

            
535
    /// Return a mutable reference to the vector of lines we should
536
    /// add to the output.
537
2612
    fn linebuf_mut(&mut self) -> Option<&mut Vec<&'a str>> {
538
2612
        match self {
539
1916
            Self::Replace { lines, .. } | Self::Insert { lines, .. } => Some(lines),
540
696
            _ => None,
541
        }
542
2612
    }
543

            
544
    /// Return the (1-indexed) line number of the first line in the
545
    /// input that comes _after_ this command, and is not affected by it.
546
    ///
547
    /// We use this line number to know which lines we should copy.
548
5176
    fn following_lines(&self) -> Option<usize> {
549
5176
        match self {
550
4038
            Self::Delete { high, .. } | Self::Replace { high, .. } => Some(high + 1),
551
242
            Self::DeleteToEnd { .. } => None,
552
896
            Self::Insert { pos, .. } => Some(pos + 1),
553
        }
554
5176
    }
555

            
556
    /// Return the (1-indexed) line number of the first line that we
557
    /// should clear from the input when processing this command.
558
    ///
559
    /// This can be the same as following_lines(), if we shouldn't
560
    /// actually remove any lines.
561
5166
    fn first_removed_line(&self) -> usize {
562
5166
        match self {
563
1118
            Self::Delete { low, .. } => *low,
564
242
            Self::DeleteToEnd { low } => *low,
565
2910
            Self::Replace { low, .. } => *low,
566
896
            Self::Insert { pos, .. } => *pos + 1,
567
        }
568
5166
    }
569

            
570
    /// Return true if this is an Insert command.
571
2572
    fn is_insert(&self) -> bool {
572
2572
        matches!(self, Self::Insert { .. })
573
2572
    }
574

            
575
    /// Extract a single command from a line iterator that yields lines
576
    /// of the diffs.  Return None if we're at the end of the iterator.
577
2847
    fn from_line_iterator<I>(iter: &mut I) -> Result<Option<Self>>
578
2847
    where
579
2847
        I: Iterator<Item = &'a str>,
580
    {
581
2847
        let command = match iter.next() {
582
2638
            Some(s) => s,
583
209
            None => return Ok(None),
584
        };
585

            
586
        // `command` can be of these forms: `Rc`, `Rd`, `N,$d`, and `Na`,
587
        // where R is a range of form `N,N`, and where N is a line number.
588

            
589
2638
        if command.len() < 2 || !command.is_ascii() {
590
6
            return Err(Error::BadDiff("command too short"));
591
2632
        }
592

            
593
2632
        let (range, command) = command.split_at(command.len() - 1);
594
2632
        let (low, high) = if let Some(comma_pos) = range.find(',') {
595
            (
596
1438
                range[..comma_pos].parse::<usize>()?,
597
1436
                Some(range[comma_pos + 1..].parse::<RangeEnd>()?),
598
            )
599
        } else {
600
1194
            (range.parse::<usize>()?, None)
601
        };
602

            
603
2620
        if low == usize::MAX {
604
2
            return Err(Error::BadDiff("range cannot begin at usize::MAX"));
605
2618
        }
606

            
607
2618
        match (low, high) {
608
1309
            (lo, Some(RangeEnd::Num(hi))) if lo > hi.into() => {
609
2
                return Err(Error::BadDiff("mis-ordered lines in range"));
610
            }
611
2616
            (_, _) => (),
612
        }
613

            
614
2616
        let mut cmd = match (command, low, high) {
615
2616
            ("d", low, None) => Self::Delete { low, high: low },
616
417
            ("d", low, Some(RangeEnd::Num(high))) => Self::Delete {
617
417
                low,
618
417
                high: high.into(),
619
417
            },
620
121
            ("d", low, Some(RangeEnd::DollarSign)) => Self::DeleteToEnd { low },
621
1920
            ("c", low, None) => Self::Replace {
622
577
                low,
623
577
                high: low,
624
577
                lines: Vec::new(),
625
577
            },
626
888
            ("c", low, Some(RangeEnd::Num(high))) => Self::Replace {
627
888
                low,
628
888
                high: high.into(),
629
888
                lines: Vec::new(),
630
888
            },
631
453
            ("a", low, None) => Self::Insert {
632
451
                pos: low,
633
451
                lines: Vec::new(),
634
451
            },
635
4
            (_, _, _) => return Err(Error::BadDiff("can't parse command line")),
636
        };
637

            
638
2612
        if let Some(ref mut linebuf) = cmd.linebuf_mut() {
639
            // The 'c' and 'a' commands take a series of lines followed by a
640
            // line containing a period.
641
            loop {
642
8922
                match iter.next() {
643
                    None => return Err(Error::BadDiff("unterminated block to insert")),
644
8922
                    Some(".") => break,
645
7006
                    Some(line) => linebuf.push(line),
646
                }
647
            }
648
696
        }
649

            
650
2612
        Ok(Some(cmd))
651
2847
    }
652
}
653

            
654
/// Iterator that wraps a line iterator and returns a sequence of
655
/// `Result<DiffCommand>`.
656
///
657
/// This iterator forces the commands to affect the file in reverse order,
658
/// so that we can use the O(n) algorithm for applying these diffs.
659
struct DiffCommandIter<'a, I>
660
where
661
    I: Iterator<Item = &'a str>,
662
{
663
    /// The underlying iterator.
664
    iter: I,
665

            
666
    /// The 'first removed line' of the last-parsed command; used to ensure
667
    /// that commands appear in reverse order.
668
    last_cmd_first_removed: Option<usize>,
669
}
670

            
671
impl<'a, I> DiffCommandIter<'a, I>
672
where
673
    I: Iterator<Item = &'a str>,
674
{
675
    /// Construct a new DiffCommandIter wrapping `iter`.
676
201
    fn new(iter: I) -> Self {
677
201
        DiffCommandIter {
678
201
            iter,
679
201
            last_cmd_first_removed: None,
680
201
        }
681
201
    }
682
}
683

            
684
impl<'a, I> Iterator for DiffCommandIter<'a, I>
685
where
686
    I: Iterator<Item = &'a str>,
687
{
688
    type Item = Result<DiffCommand<'a>>;
689
2793
    fn next(&mut self) -> Option<Result<DiffCommand<'a>>> {
690
2793
        match DiffCommand::from_line_iterator(&mut self.iter) {
691
            Err(e) => Some(Err(e)),
692
195
            Ok(None) => None,
693
2598
            Ok(Some(c)) => match (self.last_cmd_first_removed, c.following_lines()) {
694
                (Some(_), None) => Some(Err(Error::BadDiff("misordered commands"))),
695
2397
                (Some(a), Some(b)) if a < b => Some(Err(Error::BadDiff("misordered commands"))),
696
                (_, _) => {
697
2592
                    self.last_cmd_first_removed = Some(c.first_removed_line());
698
2592
                    Some(Ok(c))
699
                }
700
            },
701
        }
702
2793
    }
703
}
704

            
705
impl<'a> DiffResult<'a> {
706
    /// Construct a new DiffResult containing the provided string
707
    /// split into lines, and an expected post-transformation digest.
708
201
    fn from_str(s: &'a str, d_post: [u8; 32]) -> Self {
709
        // As per the [netdoc syntax], newlines should be discarded and ignored.
710
        //
711
        // [netdoc syntax]: https://spec.torproject.org/dir-spec/netdoc.html#netdoc-syntax
712
201
        let lines: Vec<_> = s.lines().collect();
713

            
714
201
        DiffResult { d_post, lines }
715
201
    }
716

            
717
    /// Return a new empty DiffResult with an expected
718
    /// post-transformation digests
719
195
    fn new(d_post: [u8; 32]) -> Self {
720
195
        DiffResult {
721
195
            d_post,
722
195
            lines: Vec::new(),
723
195
        }
724
195
    }
725

            
726
    /// Put every member of `lines` at the end of this DiffResult, in
727
    /// reverse order.
728
4544
    fn push_reversed(&mut self, lines: &[&'a str]) {
729
4544
        self.lines.extend(lines.iter().rev());
730
4544
    }
731

            
732
    /// Remove the 1-indexed lines from `first` through `last` inclusive.
733
    ///
734
    /// This has to move elements around within the vector, and so it
735
    /// is potentially O(n) in its length.
736
    #[cfg(any(test, feature = "slow-diff-apply"))]
737
40
    fn remove_lines(&mut self, first: usize, last: usize) -> Result<()> {
738
40
        if first > self.lines.len() || last > self.lines.len() || first == 0 || last == 0 {
739
4
            Err(Error::CantApply("line out of range"))
740
        } else {
741
36
            let n_to_remove = last - first + 1;
742
36
            if last != self.lines.len() {
743
28
                self.lines[..].copy_within((last).., first - 1);
744
28
            }
745
36
            self.lines.truncate(self.lines.len() - n_to_remove);
746
36
            Ok(())
747
        }
748
40
    }
749

            
750
    /// Insert the provided `lines` so that they appear at 1-indexed
751
    /// position `pos`.
752
    ///
753
    /// This has to move elements around within the vector, and so it
754
    /// is potentially O(n) in its length.
755
    #[cfg(any(test, feature = "slow-diff-apply"))]
756
28
    fn insert_at(&mut self, pos: usize, lines: &[&'a str]) -> Result<()> {
757
28
        if pos > self.lines.len() + 1 || pos == 0 {
758
4
            Err(Error::CantApply("position out of range"))
759
        } else {
760
24
            let orig_len = self.lines.len();
761
24
            self.lines.resize(self.lines.len() + lines.len(), "");
762
24
            self.lines
763
24
                .copy_within(pos - 1..orig_len, pos - 1 + lines.len());
764
24
            self.lines[(pos - 1)..(pos + lines.len() - 1)].copy_from_slice(lines);
765
24
            Ok(())
766
        }
767
28
    }
768

            
769
    /// See whether the output of this diff matches the target digest.
770
    ///
771
    /// If not, return an error.
772
76
    pub fn check_digest(&self) -> Result<()> {
773
        use digest::Digest;
774
        use tor_llcrypto::d::Sha3_256;
775
76
        let mut d = Sha3_256::new();
776
438
        for line in &self.lines {
777
362
            d.update(line.as_bytes());
778
362
            d.update(b"\n");
779
362
        }
780
76
        if d.finalize() == self.d_post.into() {
781
39
            Ok(())
782
        } else {
783
37
            Err(Error::CantApply("Wrong digest after applying diff"))
784
        }
785
76
    }
786
}
787

            
788
impl<'a> Display for DiffResult<'a> {
789
208
    fn fmt(&self, f: &mut Formatter<'_>) -> std::result::Result<(), std::fmt::Error> {
790
12553
        for elt in &self.lines {
791
12345
            writeln!(f, "{}", elt)?;
792
        }
793
208
        Ok(())
794
208
    }
795
}
796

            
797
#[cfg(test)]
798
mod test {
799
    // @@ begin test lint list maintained by maint/add_warning @@
800
    #![allow(clippy::bool_assert_comparison)]
801
    #![allow(clippy::clone_on_copy)]
802
    #![allow(clippy::dbg_macro)]
803
    #![allow(clippy::mixed_attributes_style)]
804
    #![allow(clippy::print_stderr)]
805
    #![allow(clippy::print_stdout)]
806
    #![allow(clippy::single_char_pattern)]
807
    #![allow(clippy::unwrap_used)]
808
    #![allow(clippy::unchecked_time_subtraction)]
809
    #![allow(clippy::useless_vec)]
810
    #![allow(clippy::needless_pass_by_value)]
811
    //! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
812

            
813
    use rand::seq::IndexedRandom;
814
    use tor_basic_utils::test_rng::testing_rng;
815

            
816
    use super::*;
817

            
818
    #[test]
819
    fn remove() -> Result<()> {
820
        let example = DiffResult::from_str("1\n2\n3\n4\n5\n6\n7\n8\n9\n", [0; 32]);
821

            
822
        let mut d = example.clone();
823
        d.remove_lines(5, 7)?;
824
        assert_eq!(d.to_string(), "1\n2\n3\n4\n8\n9\n");
825

            
826
        let mut d = example.clone();
827
        d.remove_lines(1, 9)?;
828
        assert_eq!(d.to_string(), "");
829

            
830
        let mut d = example.clone();
831
        d.remove_lines(1, 1)?;
832
        assert_eq!(d.to_string(), "2\n3\n4\n5\n6\n7\n8\n9\n");
833

            
834
        let mut d = example.clone();
835
        d.remove_lines(6, 9)?;
836
        assert_eq!(d.to_string(), "1\n2\n3\n4\n5\n");
837

            
838
        let mut d = example.clone();
839
        assert!(d.remove_lines(6, 10).is_err());
840
        assert!(d.remove_lines(0, 1).is_err());
841
        assert_eq!(d.to_string(), "1\n2\n3\n4\n5\n6\n7\n8\n9\n");
842

            
843
        Ok(())
844
    }
845

            
846
    #[test]
847
    fn insert() -> Result<()> {
848
        let example = DiffResult::from_str("1\n2\n3\n4\n5\n", [0; 32]);
849
        let mut d = example.clone();
850
        d.insert_at(3, &["hello", "world"])?;
851
        assert_eq!(d.to_string(), "1\n2\nhello\nworld\n3\n4\n5\n");
852

            
853
        let mut d = example.clone();
854
        d.insert_at(6, &["hello", "world"])?;
855
        assert_eq!(d.to_string(), "1\n2\n3\n4\n5\nhello\nworld\n");
856

            
857
        let mut d = example.clone();
858
        assert!(d.insert_at(0, &["hello", "world"]).is_err());
859
        assert!(d.insert_at(7, &["hello", "world"]).is_err());
860
        Ok(())
861
    }
862

            
863
    #[test]
864
    fn push_reversed() {
865
        let mut d = DiffResult::new([0; 32]);
866
        d.push_reversed(&["7", "8", "9"]);
867
        assert_eq!(d.to_string(), "9\n8\n7\n");
868
        d.push_reversed(&["world", "hello", ""]);
869
        assert_eq!(d.to_string(), "9\n8\n7\n\nhello\nworld\n");
870
    }
871

            
872
    #[test]
873
    fn apply_command_simple() {
874
        let example = DiffResult::from_str("a\nb\nc\nd\ne\nf\n", [0; 32]);
875

            
876
        let mut d = example.clone();
877
        assert_eq!(d.to_string(), "a\nb\nc\nd\ne\nf\n".to_string());
878
        assert!(DiffCommand::DeleteToEnd { low: 5 }.apply_to(&mut d).is_ok());
879
        assert_eq!(d.to_string(), "a\nb\nc\nd\n".to_string());
880

            
881
        let mut d = example.clone();
882
        assert!(
883
            DiffCommand::Delete { low: 3, high: 5 }
884
                .apply_to(&mut d)
885
                .is_ok()
886
        );
887
        assert_eq!(d.to_string(), "a\nb\nf\n".to_string());
888

            
889
        let mut d = example.clone();
890
        assert!(
891
            DiffCommand::Replace {
892
                low: 3,
893
                high: 5,
894
                lines: vec!["hello", "world"]
895
            }
896
            .apply_to(&mut d)
897
            .is_ok()
898
        );
899
        assert_eq!(d.to_string(), "a\nb\nhello\nworld\nf\n".to_string());
900

            
901
        let mut d = example.clone();
902
        assert!(
903
            DiffCommand::Insert {
904
                pos: 3,
905
                lines: vec!["hello", "world"]
906
            }
907
            .apply_to(&mut d)
908
            .is_ok()
909
        );
910
        assert_eq!(
911
            d.to_string(),
912
            "a\nb\nc\nhello\nworld\nd\ne\nf\n".to_string()
913
        );
914
    }
915

            
916
    #[test]
917
    fn parse_command() -> Result<()> {
918
        fn parse(s: &str) -> Result<DiffCommand<'_>> {
919
            let mut iter = s.lines();
920
            let cmd = DiffCommand::from_line_iterator(&mut iter)?;
921
            let cmd2 = DiffCommand::from_line_iterator(&mut iter)?;
922
            if cmd2.is_some() {
923
                panic!("Unexpected second command");
924
            }
925
            Ok(cmd.unwrap())
926
        }
927

            
928
        fn parse_err(s: &str) {
929
            let mut iter = s.lines();
930
            let cmd = DiffCommand::from_line_iterator(&mut iter);
931
            assert!(matches!(cmd, Err(Error::BadDiff(_))));
932
        }
933

            
934
        let p = parse("3,8d\n")?;
935
        assert!(matches!(p, DiffCommand::Delete { low: 3, high: 8 }));
936
        let p = parse("3d\n")?;
937
        assert!(matches!(p, DiffCommand::Delete { low: 3, high: 3 }));
938
        let p = parse("100,$d\n")?;
939
        assert!(matches!(p, DiffCommand::DeleteToEnd { low: 100 }));
940

            
941
        let p = parse("30,40c\nHello\nWorld\n.\n")?;
942
        assert!(matches!(
943
            p,
944
            DiffCommand::Replace {
945
                low: 30,
946
                high: 40,
947
                ..
948
            }
949
        ));
950
        assert_eq!(p.lines(), Some(&["Hello", "World"][..]));
951
        let p = parse("30c\nHello\nWorld\n.\n")?;
952
        assert!(matches!(
953
            p,
954
            DiffCommand::Replace {
955
                low: 30,
956
                high: 30,
957
                ..
958
            }
959
        ));
960
        assert_eq!(p.lines(), Some(&["Hello", "World"][..]));
961

            
962
        let p = parse("999a\nHello\nWorld\n.\n")?;
963
        assert!(matches!(p, DiffCommand::Insert { pos: 999, .. }));
964
        assert_eq!(p.lines(), Some(&["Hello", "World"][..]));
965
        let p = parse("0a\nHello\nWorld\n.\n")?;
966
        assert!(matches!(p, DiffCommand::Insert { pos: 0, .. }));
967
        assert_eq!(p.lines(), Some(&["Hello", "World"][..]));
968

            
969
        parse_err("hello world");
970
        parse_err("\n\n");
971
        parse_err("$,5d");
972
        parse_err("5,6,8d");
973
        parse_err("8,5d");
974
        parse_err("6");
975
        parse_err("d");
976
        parse_err("-10d");
977
        parse_err("4,$c\na\n.");
978
        parse_err("foo");
979
        parse_err("5,10p");
980
        parse_err("18446744073709551615a");
981
        parse_err("1,18446744073709551615d");
982

            
983
        Ok(())
984
    }
985

            
986
    #[test]
987
    fn apply_transformation() -> Result<()> {
988
        let example = DiffResult::from_str("1\n2\n3\n4\n5\n6\n7\n8\n9\n", [0; 32]);
989
        let empty = DiffResult::new([1; 32]);
990

            
991
        let mut inp = example.clone();
992
        let mut out = empty.clone();
993
        DiffCommand::DeleteToEnd { low: 5 }.apply_transformation(&mut inp, &mut out)?;
994
        assert_eq!(inp.to_string(), "1\n2\n3\n4\n");
995
        assert_eq!(out.to_string(), "");
996

            
997
        let mut inp = example.clone();
998
        let mut out = empty.clone();
999
        DiffCommand::DeleteToEnd { low: 9 }.apply_transformation(&mut inp, &mut out)?;
        assert_eq!(inp.to_string(), "1\n2\n3\n4\n5\n6\n7\n8\n");
        assert_eq!(out.to_string(), "");
        let mut inp = example.clone();
        let mut out = empty.clone();
        DiffCommand::Delete { low: 3, high: 5 }.apply_transformation(&mut inp, &mut out)?;
        assert_eq!(inp.to_string(), "1\n2\n");
        assert_eq!(out.to_string(), "9\n8\n7\n6\n");
        let mut inp = example.clone();
        let mut out = empty.clone();
        DiffCommand::Replace {
            low: 5,
            high: 6,
            lines: vec!["oh hey", "there"],
        }
        .apply_transformation(&mut inp, &mut out)?;
        assert_eq!(inp.to_string(), "1\n2\n3\n4\n");
        assert_eq!(out.to_string(), "9\n8\n7\nthere\noh hey\n");
        let mut inp = example.clone();
        let mut out = empty.clone();
        DiffCommand::Insert {
            pos: 3,
            lines: vec!["oh hey", "there"],
        }
        .apply_transformation(&mut inp, &mut out)?;
        assert_eq!(inp.to_string(), "1\n2\n3\n");
        assert_eq!(out.to_string(), "9\n8\n7\n6\n5\n4\nthere\noh hey\n");
        DiffCommand::Insert {
            pos: 0,
            lines: vec!["boom!"],
        }
        .apply_transformation(&mut inp, &mut out)?;
        assert_eq!(inp.to_string(), "");
        assert_eq!(
            out.to_string(),
            "9\n8\n7\n6\n5\n4\nthere\noh hey\n3\n2\n1\nboom!\n"
        );
        let mut inp = example.clone();
        let mut out = empty.clone();
        let r = DiffCommand::Delete {
            low: 100,
            high: 200,
        }
        .apply_transformation(&mut inp, &mut out);
        assert!(r.is_err());
        let r = DiffCommand::Delete { low: 5, high: 200 }.apply_transformation(&mut inp, &mut out);
        assert!(r.is_err());
        let r = DiffCommand::Delete { low: 0, high: 1 }.apply_transformation(&mut inp, &mut out);
        assert!(r.is_err());
        let r = DiffCommand::DeleteToEnd { low: 10 }.apply_transformation(&mut inp, &mut out);
        assert!(r.is_err());
        Ok(())
    }
    #[test]
    fn header() -> Result<()> {
        fn header_from(s: &str) -> Result<([u8; 32], [u8; 32])> {
            let mut iter = s.lines();
            parse_diff_header(&mut iter)
        }
        let (a,b) = header_from(
            "network-status-diff-version 1
hash B03DA3ACA1D3C1D083E3FF97873002416EBD81A058B406D5C5946EAB53A79663 F6789F35B6B3BA58BB23D29E53A8ED6CBB995543DBE075DD5671481C4BA677FB"
        )?;
        assert_eq!(
            &a[..],
            hex::decode("B03DA3ACA1D3C1D083E3FF97873002416EBD81A058B406D5C5946EAB53A79663")?
        );
        assert_eq!(
            &b[..],
            hex::decode("F6789F35B6B3BA58BB23D29E53A8ED6CBB995543DBE075DD5671481C4BA677FB")?
        );
        assert!(header_from("network-status-diff-version 2\n").is_err());
        assert!(header_from("").is_err());
        assert!(header_from("5,$d\n1,2d\n").is_err());
        assert!(header_from("network-status-diff-version 1\n").is_err());
        assert!(
            header_from(
                "network-status-diff-version 1
hash x y
5,5d"
            )
            .is_err()
        );
        assert!(
            header_from(
                "network-status-diff-version 1
hash x y
5,5d"
            )
            .is_err()
        );
        assert!(
            header_from(
                "network-status-diff-version 1
hash AA BB
5,5d"
            )
            .is_err()
        );
        assert!(
            header_from(
                "network-status-diff-version 1
oh hello there
5,5d"
            )
            .is_err()
        );
        assert!(header_from("network-status-diff-version 1
hash B03DA3ACA1D3C1D083E3FF97873002416EBD81A058B406D5C5946EAB53A79663 F6789F35B6B3BA58BB23D29E53A8ED6CBB995543DBE075DD5671481C4BA677FB extra").is_err());
        Ok(())
    }
    #[test]
    fn apply_simple() {
        let pre = include_str!("../testdata/consensus1.txt");
        let diff = include_str!("../testdata/diff1.txt");
        let post = include_str!("../testdata/consensus2.txt");
        let result = apply_diff_trivial(pre, diff).unwrap();
        assert!(result.check_digest().is_ok());
        assert_eq!(result.to_string(), post);
    }
    #[test]
    fn sort_order() -> Result<()> {
        fn cmds(s: &str) -> Result<Vec<DiffCommand<'_>>> {
            let mut out = Vec::new();
            for cmd in DiffCommandIter::new(s.lines()) {
                out.push(cmd?);
            }
            Ok(out)
        }
        let _ = cmds("6,9d\n5,5d\n")?;
        assert!(cmds("5,5d\n6,9d\n").is_err());
        assert!(cmds("5,5d\n6,6d\n").is_err());
        assert!(cmds("5,5d\n5,6d\n").is_err());
        Ok(())
    }
    /// Test for cons diff using a random word generator.
    #[test]
    fn cons_diff() {
        // cat /usr/share/dict/words | sort -R | head -n 20 | sed 's/^/"/g' | sed 's/$/",/g'
        const WORDS: &[&str] = &[
            "citole",
            "aflow",
            "plowfoot",
            "coom",
            "retape",
            "perish",
            "overstifle",
            "ramshackle",
            "Romeo",
            "alme",
            "expressivity",
            "Kieffer",
            "tobe",
            "pronucleus",
            "countersconce",
            "puli",
            "acupunctuate",
            "heterolysis",
            "unwattled",
            "bismerpund",
        ];
        let rng = &mut testing_rng();
        let mut left = (0..1000)
            .map(|_| WORDS.choose(rng).unwrap().to_string() + "\n")
            .collect::<String>();
        left += "directory-signature foo bar\n";
        let mut right = (0..1015)
            .map(|_| WORDS.choose(rng).unwrap().to_string() + "\n")
            .collect::<String>();
        right += "directory-signature foo baz\n";
        let diff = gen_cons_diff(&left, &right).unwrap();
        let check = apply_diff(&left, &diff, None).unwrap().to_string();
        assert_eq!(right, check);
    }
    #[test]
    fn dot_line() {
        let base = "";
        let target = "foo\nbar\n.\nbaz\nfoo\n";
        assert_eq!(
            gen_ed_diff(base, target).unwrap_err(),
            GenEdDiffError::ContainsDotLine { lno: 3 },
        );
        // Also check for dot lines with trailing spaces.
        let target = "foo\nbar\n.   \t \nbaz\nfoo\n";
        assert_eq!(
            gen_ed_diff(base, target).unwrap_err(),
            GenEdDiffError::ContainsDotLine { lno: 3 },
        );
        // A line starting with a dot and not ending in WS shall be fine though.
        let target = "foo\nbar\n.   foo\nbaz\nfoo\n";
        let _ = gen_ed_diff(base, target).unwrap();
        // Use gen_cons_diff here to assume that it is actually applied.
        let base = "directory-signature foo baz\n";
        let target = ".foo bar\n. bar\ndirectory-signature foo baz\n";
        assert_eq!(
            gen_cons_diff(base, target).unwrap(),
            "network-status-diff-version 1\n\
            hash D8138DC27D9A66F5760058A6BCB71B755462B9D26B811828F124D036DE329A58 \
            506AC3A4407BC5305DD0D08FED3F09C2FE69847541F642A8FD13D3BD06FFE432\n\
            1,$d\n\
            0a\n\
            .foo bar\n\
            . bar\n\
            directory-signature foo baz\n\
            .\n"
        );
    }
    #[test]
    fn missing_newline() {
        let base = "";
        let target = "foo\nbar\nbaz";
        assert_eq!(
            gen_ed_diff(base, target).unwrap_err(),
            GenEdDiffError::MissingUnixLineEnding { lno: 3 }
        );
    }
    #[test]
    fn mixed_with_crlf() {
        let base = "";
        let target = "foo\r\nbar\r\nbaz\nhello\r\n";
        assert_eq!(
            gen_ed_diff(base, target).unwrap_err(),
            GenEdDiffError::MissingUnixLineEnding { lno: 1 }
        );
    }
}