1
//! Define helpers for working with types in constant time.
2

            
3
use derive_deftly::{Deftly, define_derive_deftly};
4
use subtle::{Choice, ConditionallySelectable, ConstantTimeEq};
5
use zeroize::Zeroize;
6

            
7
#[cfg(feature = "memquota-memcost")]
8
use tor_memquota_cost::derive_deftly_template_HasMemoryCost;
9

            
10
define_derive_deftly! {
11
    /// Derives [`subtle::ConstantTimeEq`] on structs for which all fields
12
    /// already implement it. Note that this does NOT work on fields which are
13
    /// arrays of type `T`, even if `T` implements [`subtle::ConstantTimeEq`].
14
    /// Arrays do not directly implement [`subtle::ConstantTimeEq`] and instead
15
    /// dereference to a slice, `[T]`, which does. See subtle!114 for a possible
16
    /// future resolution.
17
    export ConstantTimeEq for struct:
18

            
19
    impl<$tgens> ConstantTimeEq for $ttype
20
    where $twheres
21
          $( $ftype : ConstantTimeEq , )
22
    {
23
1538
        fn ct_eq(&self, other: &Self) -> subtle::Choice {
24
            match (self, other) {
25
                $(
26
                    (${vpat fprefix=self_}, ${vpat fprefix=other_}) => {
27
                        $(
28
                            $<self_ $fname>.ct_eq($<other_ $fname>) &
29
                        )
30
                        subtle::Choice::from(1)
31
                    },
32
                )
33
            }
34
        }
35
    }
36
}
37
define_derive_deftly! {
38
    /// Derives [`core::cmp::PartialEq`] on types which implement
39
    /// [`subtle::ConstantTimeEq`] by calling [`subtle::ConstantTimeEq::ct_eq`].
40
    export PartialEqFromCtEq:
41

            
42
    impl<$tgens> PartialEq for $ttype
43
    where $twheres
44
          $ttype : ConstantTimeEq
45
    {
46
37134
        fn eq(&self, other: &Self) -> bool {
47
            self.ct_eq(other).into()
48
        }
49
    }
50
}
51
pub(crate) use {derive_deftly_template_ConstantTimeEq, derive_deftly_template_PartialEqFromCtEq};
52

            
53
/// A byte array of length N for which comparisons are performed in constant
54
/// time.
55
///
56
/// # Limitations
57
///
58
/// It is possible to avoid constant time comparisons here, just by using the
59
/// `as_ref()` and `as_mut()` methods.  They should therefore be approached with
60
/// some caution.
61
///
62
/// (The decision to avoid implementing `Deref`/`DerefMut` is deliberate.)
63
#[allow(clippy::derived_hash_with_manual_eq)]
64
#[derive(Clone, Copy, Debug, Hash, Zeroize, Deftly)]
65
#[cfg_attr(feature = "memquota-memcost", derive_deftly(HasMemoryCost))]
66
pub struct CtByteArray<const N: usize>([u8; N]);
67

            
68
impl<const N: usize> ConstantTimeEq for CtByteArray<N> {
69
406660181
    fn ct_eq(&self, other: &Self) -> Choice {
70
406660181
        self.0.ct_eq(&other.0)
71
406660181
    }
72
}
73

            
74
impl<const N: usize> PartialEq for CtByteArray<N> {
75
306385536
    fn eq(&self, other: &Self) -> bool {
76
306385536
        self.ct_eq(other).into()
77
306385536
    }
78
}
79
impl<const N: usize> Eq for CtByteArray<N> {}
80

            
81
impl<const N: usize> From<[u8; N]> for CtByteArray<N> {
82
10172308
    fn from(value: [u8; N]) -> Self {
83
10172308
        Self(value)
84
10172308
    }
85
}
86

            
87
impl<const N: usize> From<CtByteArray<N>> for [u8; N] {
88
16517
    fn from(value: CtByteArray<N>) -> Self {
89
16517
        value.0
90
16517
    }
91
}
92

            
93
impl<const N: usize> Ord for CtByteArray<N> {
94
3454728
    fn cmp(&self, other: &Self) -> std::cmp::Ordering {
95
        // At every point, this value will be set to:
96
        //       0 if a[i]==b[i] for all i considered so far.
97
        //       a[i] - b[i] for the lowest i that has a nonzero a[i] - b[i].
98
3454728
        let mut first_nonzero_difference = 0_i16;
99

            
100
82020072
        for (a, b) in self.0.iter().zip(other.0.iter()) {
101
82020072
            let difference = i16::from(*a) - i16::from(*b);
102
82020072

            
103
82020072
            // If it's already set to a nonzero value, this conditional
104
82020072
            // assignment does nothing. Otherwise, it sets it to `difference`.
105
82020072
            //
106
82020072
            // The use of conditional_assign and ct_eq ensures that the compiler
107
82020072
            // won't short-circuit our logic here and end the loop (or stop
108
82020072
            // computing differences) on the first nonzero difference.
109
82020072
            first_nonzero_difference
110
82020072
                .conditional_assign(&difference, first_nonzero_difference.ct_eq(&0));
111
82020072
        }
112

            
113
        // This comparison with zero is not itself constant-time, but that's
114
        // okay: we only want our Ord function not to leak the array values.
115
3454728
        first_nonzero_difference.cmp(&0)
116
3454728
    }
117
}
118

            
119
impl<const N: usize> PartialOrd for CtByteArray<N> {
120
2419924
    fn partial_cmp(&self, other: &Self) -> Option<std::cmp::Ordering> {
121
2419924
        Some(self.cmp(other))
122
2419924
    }
123
}
124

            
125
impl<const N: usize> AsRef<[u8; N]> for CtByteArray<N> {
126
1598990
    fn as_ref(&self) -> &[u8; N] {
127
1598990
        &self.0
128
1598990
    }
129
}
130

            
131
impl<const N: usize> AsMut<[u8; N]> for CtByteArray<N> {
132
25434
    fn as_mut(&mut self) -> &mut [u8; N] {
133
25434
        &mut self.0
134
25434
    }
135
}
136

            
137
/// Try to find an item in a slice without leaking where and whether the
138
/// item was found.
139
///
140
/// If there is any item `x` in the `array` for which `matches(x)`
141
/// is true, this function will return a reference to one such
142
/// item.  (We don't specify which.)
143
///
144
/// Otherwise, this function returns none.
145
///
146
/// We evaluate `matches` on every item of the array, and try not to
147
/// leak by timing which element (if any) matched.  Note that if
148
/// `matches` itself has side channels, this function can't hide them.
149
///
150
/// Note that this doesn't necessarily do a constant-time comparison,
151
/// and that it is not constant-time for the found/not-found case.
152
194
pub fn ct_lookup<T, F>(array: &[T], matches: F) -> Option<&T>
153
194
where
154
194
    F: Fn(&T) -> Choice,
155
{
156
    // ConditionallySelectable isn't implemented for usize, so we need
157
    // to use u64.
158
194
    let mut idx: u64 = 0;
159
194
    let mut found: Choice = 0.into();
160

            
161
1838
    for (i, x) in array.iter().enumerate() {
162
1838
        let equal = matches(x);
163
1838
        idx.conditional_assign(&(i as u64), equal);
164
1838
        found.conditional_assign(&equal, equal);
165
1838
    }
166

            
167
194
    if found.into() {
168
190
        Some(&array[idx as usize])
169
    } else {
170
4
        None
171
    }
172
194
}
173

            
174
#[cfg(test)]
175
mod test {
176
    // @@ begin test lint list maintained by maint/add_warning @@
177
    #![allow(clippy::bool_assert_comparison)]
178
    #![allow(clippy::clone_on_copy)]
179
    #![allow(clippy::dbg_macro)]
180
    #![allow(clippy::mixed_attributes_style)]
181
    #![allow(clippy::print_stderr)]
182
    #![allow(clippy::print_stdout)]
183
    #![allow(clippy::single_char_pattern)]
184
    #![allow(clippy::unwrap_used)]
185
    #![allow(clippy::unchecked_time_subtraction)]
186
    #![allow(clippy::useless_vec)]
187
    #![allow(clippy::needless_pass_by_value)]
188
    //! <!-- @@ end test lint list maintained by maint/add_warning @@ -->
189

            
190
    use super::*;
191
    use rand::Rng;
192
    use tor_basic_utils::test_rng;
193

            
194
    #[allow(clippy::nonminimal_bool)]
195
    #[test]
196
    fn test_comparisons() {
197
        let num = 200;
198
        let mut rng = test_rng::testing_rng();
199

            
200
        let mut array: Vec<CtByteArray<32>> =
201
            (0..num).map(|_| rng.random::<[u8; 32]>().into()).collect();
202
        array.sort();
203

            
204
        for i in 0..num {
205
            assert_eq!(array[i], array[i]);
206
            assert!(!(array[i] < array[i]));
207
            assert!(!(array[i] > array[i]));
208

            
209
            for j in (i + 1)..num {
210
                // Note that this test will behave incorrectly if the rng
211
                // generates the same 256 value twice, but that's ridiculously
212
                // implausible.
213
                assert!(array[i] < array[j]);
214
                assert_ne!(array[i], array[j]);
215
                assert!(array[j] > array[i]);
216
                assert_eq!(
217
                    array[i].cmp(&array[j]),
218
                    array[j].as_ref().cmp(array[i].as_ref()).reverse()
219
                );
220
            }
221
        }
222
    }
223

            
224
    #[test]
225
    fn test_lookup() {
226
        use super::ct_lookup as lookup;
227
        use subtle::ConstantTimeEq;
228
        let items = vec![
229
            "One".to_string(),
230
            "word".to_string(),
231
            "of".to_string(),
232
            "every".to_string(),
233
            "length".to_string(),
234
        ];
235
        let of_word = lookup(&items[..], |i| i.len().ct_eq(&2));
236
        let every_word = lookup(&items[..], |i| i.len().ct_eq(&5));
237
        let no_word = lookup(&items[..], |i| i.len().ct_eq(&99));
238
        assert_eq!(of_word.unwrap(), "of");
239
        assert_eq!(every_word.unwrap(), "every");
240
        assert_eq!(no_word, None);
241
    }
242
}